fix(core): Fix shipping price when the promotion is not applicable anymo #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow great catch, thank you! |
michaelbromley
added a commit
that referenced
this pull request
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following issue;
assume that we have a shipping promotion, and it gives free delivery after 30 USD.
The customer added some items to the cart and reached the threshold of free delivery. Shipping price is free as expected.
Then he removed one item from the cart and if cart total is lower than threshold of free delivery, the shipping price should be calculated again.
So we should removed previously added adjustments from shipping line items if there isn't applicable promotion for shipping.